Guillaume Gelin

Results 252 comments of Guillaume Gelin

Will be hard for me to judge if the book is awesome or not without a copy :)

Amazon reviews are favorable, the preview looks great, let's get this merged. :)

Hey, thanks for raising the issue and sorry for the long time to answer. Your code has many other Mypy errors as is, but it can be replicated with this...

Yeah, the Compose file probably needs a refresh; it's been a while since it was implemented by an external contributor and a lot has changed in the meantime. I know...

From what I've seen so far, this is PostHog's biggest shortcoming compared to Mixpanel. (But don't get me wrong, PostHog is impressive!) Is there any workaround?

Go ahead! The only requirements are that the DX/library API be identical to the JS SDK and that our Python code remain consistent with what we already have. :)

I don't think so, but we only need to burn one token to register the VCR.py cassette. Subsequent tests won't revoke the token as long as this cassette is being...

Yes, you need to create an integration so that you can generate a new token manually and burn it while generating the cassette for this test.

Oh, good catch! It looks like we missed this commit from two years ago: https://github.com/makenotion/notion-sdk-js/commit/0877d3478c680bf6b5860cfc21e7ab012084aad4 We should implement this "Get token" endpoint as well, and add the same changes for...

Also, if we implement the client id and secret authorization as well as the "Get token" endpoint, we should update the tests so that they run entirely with these environment...