Fabrizio Ruggeri

Results 91 comments of Fabrizio Ruggeri

Hello @fromage9747, can you please create a reproduction repo maybe?

Ok, I don't understand very well the problem. By the way, I saw master was very old while I had a ready release. So I did a release (which in...

Ok, in the version which is on master now, after publishing it, the problem should be solved. The reference_field is not used anymore as id to lookup on the counter...

the `_getCounterReferenceField` returns the value reference for the counter. This is then incremented looking at id and those values. So, because of the id filtering the problem should never appear....

The id unicity (for sequences) is delegated to the developer. What if, on db, there are the different reference fields with the same name too? The problem remains. To prevent...

Sorry, I'm starting to see what you say. Let me add a test to be sure

PS, I like describing the software constraints through tests as you may have understood

I think your boss is right. You just have to tell it to me and I'll provide :) By the way I had no time to create the test because...

There is an open PR (#10) on this problem. We still are not able to fix the problem mainly because of how mongoose hooks works for `findOneAndUpdate`.

There is a list on the PR. By the way: - Using `multi: true` during an update should work the same - The same functionality should work for `referenced fields`...