rami3l
> I think so, I'll try to get something up this week. @djc Thanks :) > Do we need to wait for release process work? I still want to, but...
@ChrisDenton I agree! There's one more PR from @djc (#4631) that we'd like to ship as discussed above, but apart from that I believe that's pretty much it for this...
@grahamc Thanks for submitting this patch! Would you mind providing more info about the rationale of this change though? Looking at the solution you are trying to resolve, I'm a...
Thanks for the report! However this is weird to me since I believe we already have tests for that two cases you have mentioned: https://github.com/rust-lang/rustup/blob/96bd8f2d0efa6d90f56beebc005729ab9909fac3/tests/suite/cli_misc.rs#L696-L734 ... would you mind providing...
> does the lint only show up on the default toolchain? No, as seen in the second test case.
> I'm on 1.28.2, and I'm doing this with `rust-analyzer +beta`. `rust-analyzer` is a bit particular because it is a `DUP_TOOL` meaning you can have a local installation that shadows...
@vagreargnatry Thanks for your report! FYI we do hardcode 22000 in the installation helper because it is known to work at least at the time of writing: https://github.com/rust-lang/rustup/blob/3f6b75b20f550015359ed98a20912b7cecc55980/src/cli/self_update/windows.rs#L309-L314 ... are...
I agree with @djc that we should go with option 2; doing such hotfixes definitely aligns better with what rustup has been doing regarding release manifests.
> ``` > $ RUSTUP_TOOLCHAIN=nightly rustup show active-toolchain > nightly-x86_64-pc-windows-msvc > active because: environment override by RUSTUP_TOOLCHAIN > ``` Indeed, breaking that into two lines might be a good idea....
@rbtcollins @djc Instead of changing to `=` and `-` combined as proposed above, what if we keep the `-`, and add indentation to the mix (IIRC it should be 2...