Ramez Ragaa

Results 49 comments of Ramez Ragaa

duplicate of https://github.com/unoplatform/uno/issues/12401? Edit; no, it isn't. I misread

Output of `ShowLocalVisualTree` on the problematic stackpanel on Gtk on Windows (repro): ``` >Uno.UI.Xaml.Islands.XamlIsland-(1024.0x768.0)@(0.0,0.0) d:1024.0,768.0 HA=Stretch,VA=Stretch >Uno.UI.Xaml.Controls.WindowChrome-(1024.0x768.0)@(0.0,0.0) d:532.0,555.0 HA=Stretch,VA=Stretch >Microsoft.UI.Xaml.Controls.ContentPresenter-(1024.0x768.0)@(0.0,0.0) d:532.0,555.0 HA=Stretch,VA=Stretch >Microsoft.UI.Xaml.Controls.Frame-(1024.0x768.0)@(0.0,0.0) d:532.0,555.0 HA=Stretch,VA=Stretch >Microsoft.UI.Xaml.Controls.ContentPresenter-(1024.0x768.0)@(0.0,0.0) d:532.0,555.0 HA=Stretch,VA=Stretch >SamplesApp.MainPage-(1024.0x768.0)@(0.0,0.0) d:532.0,555.0...

Output on Linux (working correctly): ``` >Uno.UI.Xaml.Islands.XamlIsland-(1024.0x768.0)@(0.0,0.0) d:1024.0,768.0 HA=Stretch,VA=Stretch >Uno.UI.Xaml.Controls.WindowChrome-(1024.0x768.0)@(0.0,0.0) d:536.0,558.0 HA=Stretch,VA=Stretch >Microsoft.UI.Xaml.Controls.ContentPresenter-(1024.0x768.0)@(0.0,0.0) d:536.0,558.0 HA=Stretch,VA=Stretch >Microsoft.UI.Xaml.Controls.Frame-(1024.0x768.0)@(0.0,0.0) d:536.0,558.0 HA=Stretch,VA=Stretch >Microsoft.UI.Xaml.Controls.ContentPresenter-(1024.0x768.0)@(0.0,0.0) d:536.0,558.0 HA=Stretch,VA=Stretch >SamplesApp.MainPage-(1024.0x768.0)@(0.0,0.0) d:536.0,558.0 HA=Stretch,VA=Stretch >Uno.UI.Samples.Controls.SampleChooserControl-'sampleControl'-(1024.0x768.0)@(0.0,0.0) d:536.0,558.0 HA=Stretch,VA=Stretch >Microsoft.UI.Xaml.Controls.SplitView-'SplitView'-(1024.0x768.0)@(0.0,0.0) d:536.0,558.0 HA=Stretch,VA=Stretch...

This appear to also be happening on Ubuntu (both firefox and chrome as far as I've tried). The log on firefox gives this: ![image](https://github.com/unoplatform/uno/assets/66218781/f117d4f9-e204-4c6c-8628-045b69d3fddd) The log on chrome is not...

There's also a workaround for `KeepInteriorCornersSquare` in ComboBox_themeresources.xaml too I think

Shouldn't this be controlled in the `SkiaHostBuilder` instead? i.e. ``` SkiaHostBuilder.Create() ... .UseX11() .UseLinuxFrameBuffer() ``` should use X11 if available and fall back to FB, while ``` SkiaHostBuilder.Create() ... .UseLinuxFrameBuffer()...

this builds on top of #15875

Before: ![image](https://github.com/unoplatform/uno/assets/66218781/cd39a2bf-08d2-443f-8d43-b9e343373d05) After (uno left, winui right): ![image](https://github.com/unoplatform/uno/assets/66218781/31a41b0e-9f37-4e77-92c0-7a2ac0b8ce0a)

I have quite a few X11 PRs open, so let's put this one on hold until they merge so I don't have to deal with a million conflicts.