react-location-picker icon indicating copy to clipboard operation
react-location-picker copied to clipboard

Published 20 hours ago • verified publisher icon rameshsyn

Replace the unmaintained/outdated react-google-maps dependency

Open rideyourstyle opened this issue 5 years ago • 5 comments

Are there any intentions to replace the unmaintained (react-google-maps) dependency with a maintainend one?

The package @react-google-maps/api is a maintained one, based on react-google-maps.

When I use the react-location-picker with react 16.13.1 we have some deprecation warnings. That's also the reason why we moved from react-google-maps (last commit 2 years ago) to @react-google-maps/api

rideyourstyle avatar Apr 27 '20 09:04 rideyourstyle

@rideyourstyle Thanks for raising the issue. Didn't know about the @react-google-maps/api. Yes, I want to replace it. Would you mind sending a PR replacing the react-google-maps package? seems like you already have experience with it. react-location-picker only uses a few components from react-google-maps, so it shouldn't take time replacing it.

rameshsyn avatar Apr 27 '20 10:04 rameshsyn

I will give it a try. I have no expirience with "modules" but it seems possible to replace it ;-)

rideyourstyle avatar Apr 27 '20 15:04 rideyourstyle

@rideyourstyle 👍

rameshsyn avatar Apr 27 '20 18:04 rameshsyn

Done #24 :-) The replacemant itself was easy, but it was the first time I work on a compiled lib. I added also mapOptions to modify the map.

Because componentWillReceiveProps causes deprecation warnings, I will replace it in my fork.

rideyourstyle avatar Apr 29 '20 08:04 rideyourstyle

I think I can close this PR, because there will be way more issuses with this librarie(s) in the meantime...

rideyourstyle avatar Apr 03 '24 12:04 rideyourstyle