trigonoparty icon indicating copy to clipboard operation
trigonoparty copied to clipboard

Include an option to draw values in canvas.

Open ramesaliyev opened this issue 5 years ago • 4 comments

Like discussed in here and demonstrated in here add a option to show values of lines in diagram like bazooka2th did in his/her work.

ramesaliyev avatar Oct 07 '18 10:10 ramesaliyev

untitled720

I tried this, and didn't like the results.

gokaygurcan avatar Oct 08 '18 22:10 gokaygurcan

Hi, thank you for taking care of this! Actually this was the exact result i was hoping to achieve. It seems a little bit crowded of course, (is this the reason you didnt like it?) but this will be optional and defaultly disabled. Also users can use this with short names, that would be more clear.

ramesaliyev avatar Oct 09 '18 07:10 ramesaliyev

Hi again, totally forgot this one. anyway. i didn't like it because in the given example, everything is static until you start to move stuff. but here, it moves constantly, so it requires to calculate changes lots of times in every second and to update the canvas element. i saw some discrepancies between the values next to sin/cos/tan/etc. and values on the right pane.

but still, i can wrap it up and create a pull request. then we can talk about possible improvements if you want.

best, G.

gokaygurcan avatar Oct 13 '18 15:10 gokaygurcan

Hi! Sorry for late answer, i was really crowded. Actually i think its good enough right now, and it would be good if you wrap it up because i'm planning changes which may introduce breaking changes for improvements which done in current codebase.

One of improvement that i'm planning to do is moving all calculations to another place. So this will solve discrepancies that you mentioned i think.

ramesaliyev avatar Oct 18 '18 10:10 ramesaliyev