ramda.github.io icon indicating copy to clipboard operation
ramda.github.io copied to clipboard

"name-filter" will lead to confusion

Open xp44mm opened this issue 4 years ago • 5 comments

This is a issue about the help documentation page.

In the browser, the text input box prompts for a drop-down list, which is a list of user registration names.

<input class="form-control" tabindex="1" id="name-filter" ... >

It is recommended that you rename the name "name-filter" of the id to avoid prompts for browser errors.

xp44mm avatar Sep 02 '21 02:09 xp44mm

I'm sorry, I don't follow this.

What error are we trying to avoid?

CrossEye avatar Sep 03 '21 18:09 CrossEye

I'm not quite sure if modifying the id doesn't include "name" to fix this conflict.

xp44mm avatar Sep 05 '21 00:09 xp44mm

I'm sorry. I still don't understand what issue you're having. Do you have screenshots or console sessions or something that can help explain it? What browser are you using? When do you see the error?

CrossEye avatar Sep 05 '21 01:09 CrossEye

x

xp44mm avatar Sep 05 '21 03:09 xp44mm

Hmm, I've never seen that. But I certainly have no issue renaming the field. Perhaps something like function-name-filter.

If you feel like raising a PR for this, it would be in the https://github.com/ramda/ramda.github.io repository. If not, I'll try to change it next time I'm in there.

CrossEye avatar Sep 05 '21 19:09 CrossEye