ramda.github.io icon indicating copy to clipboard operation
ramda.github.io copied to clipboard

Remove unused symb section from docs page

Open MattMS opened this issue 9 years ago • 8 comments

I cannot seem to find this being used on the site, not even in the older versions of the docs.

There are some styles for it that I have removed in another branch for a later PR.

MattMS avatar Oct 27 '16 12:10 MattMS

https://github.com/ramda/ramda.github.io/pull/99

I think it is intended to be used?

ping @thurt

buzzdecafe avatar Oct 27 '16 12:10 buzzdecafe

there appears to be no code in publish.js to pick up the @symb tag, so it is being ignored

buzzdecafe avatar Oct 27 '16 12:10 buzzdecafe

Ah right, so this should be closed and another issue opened to support @symb in publish.js?

MattMS avatar Oct 27 '16 12:10 MattMS

@symb doesn't seem to be in the code. hmmm https://github.com/ramda/ramda.github.io/blob/master/docs/dist/ramda.js

buzzdecafe avatar Oct 27 '16 12:10 buzzdecafe

Odd. Well I've grabbed the publish.js changes from #99 and converted them to Ramda code ready to be put in another PR. I'll hold off until you can confirm if they are used, as I have no idea what they are! 😛

MattMS avatar Oct 27 '16 12:10 MattMS

i suspect a bad merge happened in there somewhere

buzzdecafe avatar Oct 27 '16 12:10 buzzdecafe

#99 modifies jsdoc/publish.js which was removed by #143 because it was unused by the build scripts.

That doesn't explain why symb isn't used in dist/ramda.js though, since that is taken straight from the ramda package.

MattMS avatar Oct 27 '16 13:10 MattMS

seems to be in the source, e.g. https://github.com/ramda/ramda/blob/50758266f8afb18c38bc2de9a12a8a4bf9707b72/src/nthArg.js

so i would expect it to show up in the next release. so i think we can close this PR

buzzdecafe avatar Oct 27 '16 13:10 buzzdecafe