Alex Stephen
Alex Stephen
@Fokko @kevinjqliu mind taking a look when you can? thanks!
@earth2marsh can you run `npm run lint` to fix the linter issues? You should be free to merge after that.
@Fokko tests added! The tests caught a handful of Pydantic issues (thought they would've been caught at runtime...), so there's a couple changes sprinkled in the models.
I meant something totally different in my comment. I responded in the PR comment, but tl;dr, let's close this issue.
@stevie9868 are you still planning on taking on the deletion vector work? I'm happy to contribute some cycles if you don't have any
Created #2287 to solve this. Unfortunately, Pydantic doesn't natively support this.
Yeah, I think this is a good idea. The original idea was too pedantic imo
This looks fantastic! Thank you for writing this!
Looks like this can be closed out