leptos-markdown icon indicating copy to clipboard operation
leptos-markdown copied to clipboard

Any plan for leptos 0.7 support?

Open opeolluwa opened this issue 1 year ago • 8 comments

opeolluwa avatar Dec 30 '24 10:12 opeolluwa

I might do it someday, but I'm not a big leptos user currently. And to be honest I'm not very happy with the current implementation.

If someone wants to create a PR I'll accept it.

rambip avatar Dec 30 '24 11:12 rambip

Oh awesome! I want to work on it.

opeolluwa avatar Dec 30 '24 11:12 opeolluwa

Screenshot 2024-12-30 at 12 16 36

I'm trying to get this setup, any tip?

opeolluwa avatar Dec 30 '24 11:12 opeolluwa

I might do it someday, but I'm not a big leptos user currently. And to be honest I'm not very happy with the current implementation. Do you want a rewrite? If someone wants to create a PR I'll accept it.

opeolluwa avatar Dec 30 '24 11:12 opeolluwa

I think I made a mistake when I tried to create rust-web-markdown, the dependency of this project. a 100% leptos implementation will probably be easier to maintain. If you have enough time to do it, I think a rewrite is the best thing to do. You can take inspiration from rust-web-markdown and also look at the git history: https://github.com/rambip/leptos-markdown/blob/96042d8e7fe843d32d9ece1c2af887daeb1aa8a2/src/render.rs

I might be wrong, maybe staying with the current implementation is the best.

rambip avatar Dec 30 '24 11:12 rambip

Thank you so so much

I think the peer dependency would do

I need to achieve something identical to this interface Screenshot_20241230-122944.jpg

opeolluwa avatar Dec 30 '24 11:12 opeolluwa

Also my project is already built in leptos 0.7x

The major thing here would be the markdown parser

opeolluwa avatar Dec 30 '24 11:12 opeolluwa

Screenshot 2024-12-30 at 12 16 36

I'm trying to get this setup, any tip?

I fixed it on the main branch

rambip avatar Dec 30 '24 12:12 rambip