Raphael Mack

Results 212 comments of Raphael Mack

I stumbled over this name and _hoped_ it would to do something useful and expected, that we would not need to check all those special cases, but all is included...

Thanks for the report. Support for the community privilege system is not yet there. We will take a look together with #169 and #47

That sound's nice, I agree. Thanks for the proposal. #57 is for sure more important than an autonomous slideshow viewer. For now I put it into the "Future Plans" milestone...

@coolo do you see why the test fails here? I see `No views in hierarchy found matching: with text: is "Large"` - can you give @remi-martin and me a small...

Ah easy. After selecting English as language is is quite straight forward to run the test locally. There it looks like a refresh is missing after switching accounts...

@remi-martin can you look into this and refresh the album after switching the account or should I?

I stepped a little into it. For me the root cause is that you only display the images from the cache. In ImageRepository.getImages() we should come back to reading also...

Furthermore the `subscribe()`-calls in CategoriesRepository and ImageRepository do not have an onError which crashes the app if for example the server does not respond with a proper HTTP result, consider...

In case we get a "304 Not Modified" HTTP response we could even drop the image from the remote.

> When should we get an error 304 ? When we are attempting to fetch the images ? (Sounds weird) Nono 304 is not an error. It only means that...