node-zillow icon indicating copy to clipboard operation
node-zillow copied to clipboard
verified publisher icon ralucas

feat(code): switch to typescript, mock zillow api calls, fix xml parser

Open blaskovicz opened this issue 7 years ago • 4 comments

blaskovicz avatar Oct 17 '18 05:10 blaskovicz

All good!

image

blaskovicz avatar Oct 17 '18 05:10 blaskovicz

This looks pretty good, thanks for the PR. Can I ask the impetus for the change to typescript, etc.? Thanks.

Richard

ralucas avatar Oct 18 '18 23:10 ralucas

Hi @ralucas I'm a big fan of Typescript when it comes to developing applications at scale since it makes refactoring and bug detection a breeze!

I did this since Typescript is my preferred language over raw JavaScript since I may need to implement this soon myself, unless @konsumer does: https://github.com/ralucas/node-zillow/issues/13.

Here's another repo I converted to Typescript successfully: https://github.com/adumont/tplink-cloud-api/commit/36d05f5224a8765b03b39a8a93ddd9945a0a6986

blaskovicz avatar Oct 18 '18 23:10 blaskovicz

Also, I'd like to add that if you know JavaScript, you almost already know typescript! Depending on the settings of the compiler and linter, it can be pretty lax with explicitly defining types (declarations, return values, function arguments, etc).

blaskovicz avatar Oct 19 '18 17:10 blaskovicz