wokkel icon indicating copy to clipboard operation
wokkel copied to clipboard

Published 20 hours ago • verified publisher icon ralphm

Add support for twisted bindAddress argument

Open sayoun opened this issue 11 years ago • 3 comments

Hello,

when using servers with multiple interfaces, we need to be able to choose which interface to use for binding the socket for the outgoing connection.

Twisted use an internal argument called bindAddress for this purpose, this pull request add support for this in the XMPP client.

Best Regards.

sayoun avatar Aug 26 '13 15:08 sayoun

@sayoun: Thanks for the patch! It would be great if you could add some unittests for the these changes, as well as a docstring for the new parameter to XMPPClient.

ralphm avatar Aug 26 '13 17:08 ralphm

Hello,

I added a docstring and a unittest for the new parameter bindAddress. Unittest has a comment explaining why we must use a callLater in order to have the unittest work, because we need to keep the reactor clean between tests otherwise it fails.

Best Regards.

sayoun avatar Aug 27 '13 08:08 sayoun

Thanks for you feedback,

I rewrote the tests according to your message, I hope this time it covers everything.

sayoun avatar Sep 09 '13 09:09 sayoun