wokkel icon indicating copy to clipboard operation
wokkel copied to clipboard

Published 20 hours ago • verified publisher icon ralphm

implement item retract + notification

Open souliane opened this issue 8 years ago • 2 comments

needs the changes from https://github.com/ralphm/wokkel/pull/13 to work (or change in wokkel/pubsub.py line 986 to directly use PubSubRequest)

souliane avatar Aug 30 '16 20:08 souliane

Thanks for this contribution! A few comments:

  • notifyRetract lacks a docstring in wokkel.iwokkel.IPubSubService (which would then be inherited in the docstring for PubSubService automatically when generating API docs.
  • notifyRetract lacks tests. I think these could be more or less a copy of the tests for notifyPublish.

I removed the dependence on #13 (which I am still looking into), merged trunk to make Travis-CI happy, and pushed by version of the branch as item-retract.

ralphm avatar Oct 04 '16 15:10 ralphm

Hi Ralph, thanks for the review. I merged your branch in mine and pushed https://github.com/souliane/wokkel/commit/cd63436e131c14f818d24b4a8332f14b1296634f

souliane avatar Oct 05 '16 22:10 souliane