pdf_signing icon indicating copy to clipboard operation
pdf_signing copied to clipboard

Signature fields

Open mstjr opened this issue 2 months ago • 2 comments

Summary

This PR introduces a new function to create and insert signature fields into PDF documents, modernizes image handling, and updates dependencies to keep the codebase current. These changes improve the flexibility, maintainability, and future compatibility of the project.


Changes

Features

Add function to create and insert easily signature fields in PDFs. (available trough the feature "signature-fields", Fixes #6)

Refactor

Switch image handling to use BufRead and Seek traits for better flexibility Enhance error handling for PDF signature processing

Maintenance

Update dependencies to latest versions Bump version to match new changes

Testing

Even if no written test are present, I : Verified PDF signature fields are created and displayed correctly. Checked image processing on multiple PDF files to ensure backward compatibility. Build passes and dependencies resolve without conflicts.

mstjr avatar Oct 03 '25 00:10 mstjr

Thanks for the PR, but I have to spend a bit more time looking into this. So I will have to do that before merging. (don't have time right now)

Why did you created a new feature flag for this?

There is also some commented code in there. Was this accidentally added?

ralpha avatar Oct 06 '25 17:10 ralpha

No specific reason, not everyone needs this feature. I just left the commented code to make it easier to find later with a CTRL+F

mstjr avatar Nov 07 '25 13:11 mstjr