ethereum-consensus add "no-default-features" build to CI to ensure things work w/o default feature set

add "no-default-features" build to CI to ensure things work w/o default feature set

Open ralexstokes opened this issue 2 years ago • 5 comments

we should have a build step like this in the CI to ensure that things also build w/o default features

https://github.com/ralexstokes/ssz-rs/blob/main/.github/workflows/ci.yml#L37

and it looks like beacon-api-client currently does not succeed!

Oct 10 '23 21:10 ralexstokes

I can take this

Oct 10 '23 21:10 yash-atreya

@yash-atreya are you still working on this ? happy to take it over the line

Dec 08 '23 09:12 distributedstatemachine

@yash-atreya are you still working on this ? happy to take it over the line

Please go ahead.

Dec 09 '23 01:12 yash-atreya

I think we just need to do this: https://github.com/ralexstokes/ethereum-consensus/pull/284/files#r1355734863

to get that PR ready to merge -- @samtvlabs if you want to make a pass at it, feel free, otherwise I can just do in the next few days

Dec 11 '23 22:12 ralexstokes

Apologies dropped this ball on this will get this over the line this weekend

Mar 01 '24 04:03 distributedstatemachine