ethereum-consensus icon indicating copy to clipboard operation
ethereum-consensus copied to clipboard

Does not compile without `serde` feature

Open DragonDev1906 opened this issue 2 years ago • 3 comments

There is a PR that tried to fix this, but it was not merged yet and I don't know if it is still current: #191

On the current main branch ethereum-consensus does not compile without the serde feature due to the reason stated in #191:

cargo check --no-default-features

DragonDev1906 avatar Aug 16 '23 13:08 DragonDev1906

thanks for raising this, I think the changes in #191 make sense but also make the code more dense than it already is, so if anything I'd possibly even just support removing the serde feature and having the library support it by default

are you doing something where this is blocking you?

ralexstokes avatar Aug 20 '23 14:08 ralexstokes

are you doing something where this is blocking you?

No, I'm likely going to need serde anyways. Even if I don't the main downside is longer compile times. For me --no-default-features -F serde is sufficient.

I just wanted to mention that the serde feature doesn't work as expected.

DragonDev1906 avatar Aug 21 '23 07:08 DragonDev1906

great, thanks for the message :)

I'll leave this open, and (1) if anyone runs into this as blocker please post here and (2) ill keep this in my queue to address sooner or later

ralexstokes avatar Aug 22 '23 16:08 ralexstokes