rakam-api icon indicating copy to clipboard operation
rakam-api copied to clipboard

Multiple quality improvements - squid:S00117, squid:S00116

Open m-ezzat opened this issue 8 years ago • 4 comments

This pull request is focused on resolving occurrences of Sonar rules squid:S00117 - Local variable and method parameter names should comply with a naming convention squid:S00116 - Field names should comply with a naming convention

You can find more information about the issues here: https://dev.eclipse.org/sonar/coding_rules#q=squid:S00117 https://dev.eclipse.org/sonar/coding_rules#q=squid:S00116

Please let me know if you have any questions.

M-Ezzat

m-ezzat avatar May 17 '16 08:05 m-ezzat

I am not sure whether you do not agree with these changes or not. Please close this PR if not.

m-ezzat avatar Jun 28 '16 22:06 m-ezzat

Oh, yep, this may be happened after fixing the conflicts

m-ezzat avatar Jun 29 '16 04:06 m-ezzat

You also make some fields static. I think it's hard to guess which variables should be static with automation tools because some of the fields are instance fields because of thread-safety issues. I would rather to keep them as they are.

buremba avatar Jun 29 '16 04:06 buremba

Ok, reverted

m-ezzat avatar Jun 29 '16 04:06 m-ezzat