Rajesh Malviya
Rajesh Malviya
Thanks for the review @gnprice, pushed a new revision, PTAL :)
Thanks for the review @gnprice, pushed a new revision, PTAL.
Thanks for the review @gnprice, pushed a new revision!
> would you be up for investigating this after the small notification tweaks that are currently on your list? @gnprice Sure, I'll self-assign it and take a at it look...
I think closing this was unintended, reopening. (It happened because of the `... fix #461.` line in commit message.)
(Just another data point of why it would be better to have our custom platform integration for some APIs) Yesterday I experimented with #128 and my [draft branch](https://github.com/zulip/zulip-flutter/compare/main...rajveermalviya:zulip-flutter:pr-android-inbox-style-notif) uses `flutter_local_notification`...
> I'd be very glad to see that as a PR Sure, I plan to send it after your PR for replacing `flutter_local_notification` lands, to avoid re-doing that work on...
Thanks for the reviews @kenclary and @chrisbobbe! Pushed a new revision @chrisbobbe, PTAL.
Thanks for the reviews @chrisbobbe and @gnprice! Pushed a new revision, PTAL.
@gnprice, I have a question about whether this implementation is desirable. Currently it creates a pending intent using the [ACTION_VIEW](https://developer.android.com/reference/android/content/Intent#ACTION_VIEW) action with a [URL payload](https://github.com/zulip/zulip-flutter/blob/07475510fcd0310f5765a6ec98edc6ab1d5a9c15/lib/api/model/notification.dart#L70-L100) for each notification. When the...