goodfirstissue icon indicating copy to clipboard operation
goodfirstissue copied to clipboard

Published 20 hours ago • verified publisher icon rajatjindal

add unit tests for goodfirstissue

Open rajatjindal opened this issue 5 years ago • 5 comments

add unit tests for goodfirstissue

rajatjindal avatar Mar 03 '19 13:03 rajatjindal

I would like to work on this if you have not done so already. This is a really cool idea!

AdamT213 avatar Apr 09 '19 16:04 AdamT213

Hi Adam,

thanks for taking the initiative.

sure go ahead. Let me know if I can help in someway.

Thanks Rajat Jindal

rajatjindal avatar Apr 10 '19 05:04 rajatjindal

I apologize for jumping the gun too quickly. Should have looked the repo over more closely. I'm not really familiar with golang so not sure I could make a meaningful contribution right now.

AdamT213 avatar Apr 10 '19 17:04 AdamT213

@rajatjindal It is currently not straight forward to write unit test for handler.go because of the golang submodule import. see https://github.com/openfaas/faas-cli/issues/324 There are couple of options listed in the above issue, but I am not sure which one is suitable for this case. The easy way to go with will be not using any sub-modules, but it might not be the best solution.

Ewocker avatar Apr 20 '19 06:04 Ewocker

I see. may be we refactor it to use Dockerfile template to fix this issue.

rajatjindal avatar Apr 21 '19 02:04 rajatjindal