sptlrx icon indicating copy to clipboard operation
sptlrx copied to clipboard

Ignore LRC file tags

Open barraIhsan opened this issue 1 year ago • 2 comments

An addition for #48, currently lrclib uses artist metadata to mark song as instrumental [ar: instrumental]

But somehow, sptlrx fail? to parse the metadata, it will show up umental] image I tried to set the .ignoreErrors to false hoping to see any error printed out, but there are no error

barraIhsan avatar Jul 11 '24 14:07 barraIhsan

Right now we are using a pretty naive algorithm to parse the .lrc file: https://github.com/raitonoberu/sptlrx/blob/c03f1cb220936a06dec44069bfb01bf66b72c3d4/services/local/local.go#L113-L136

So, we assume that every line starting with [ is a lyrics line, but, according to the Wiki page, a file can also contain various metadata (tags).

raitonoberu avatar Jul 23 '24 12:07 raitonoberu

This design also results in lyrics files which accurate to milliseconds (the format may not comply with the specification, but if we want to support variable-length lrc tags, solving the problems they bring is just a dropping by) will be displayed with a ] symbol at the beginning of the line during rendering.

YanceyChiew avatar Aug 04 '24 11:08 YanceyChiew