Tianyu Gao

Results 19 comments of Tianyu Gao

The only one failed check is fixed in https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6119.

> There are many UI changes happening in this PR within `core` directory, which should be moved to OUI, and I find the following issue has been raised: [opensearch-project/oui#1257](https://github.com/opensearch-project/oui/issues/1257) ....

@SuZhou-Joe @ruanyl I just rebased main to resolve conflicts in changelog, and your approvals were dismissed automatically. Could you approve again?

> i think it would be cool to make the #/# a [tool tip](https://oui.opensearch.org/1.5/#/display/tooltip), and it displays the names of the selected apps Thanks for your suggestion. That's cool. I...

Hi @kavilla , could you help approve again? Seems your approval was dismissed because of my commit to update description.

> Hi @raintygao, is this PR targeting 2.15 or 2.16? Hi @BionIT , there will be some new UX design updates in this part, we convert this PR to draft...

> @raintygao I guess we can close this PR now? Sure. Closed.

> have we looked into ui settings? might be a little easier. Thanks. That looks easier. But here feel like that we more need some configuration to be a role...

Seems failing test is the same as main after merging it. https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/8954435518/job/24594081770