Tianyu Gao
Tianyu Gao
Thank you. @kavilla > In the meantime I see there are some snapshots are not updated for tests. Also wanted to check. I will do some updates to snapshots. >...
@ashwin-pc Although sidecar and flyout have some similarities, they are actually totally different. And these two components should be able to exist at the same time without affecting each other....
@ashwin-pc Thanks. I agree with you that some standard UI components should be imported from OUI, like resizable button, resizable flyouts. Once OUI support these components we can use them...
@ashwin-pc Sure. I don't know if there is a team support new features in OUI, if not, I can work on supporting this. Since I have ever not been working...
Sure, i will update test cases and test sections soon. Sorry for the missing test part, i'm trying hard to make time for this. In terms of code structure, this...
> [src/core/public/overlays/overlay_service.ts](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/5920?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#diff-c3JjL2NvcmUvcHVibGljL292ZXJsYXlzL292ZXJsYXlfc2VydmljZS50cw==) 0.00% [4 Missing ⚠️ ](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/5920?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) > [...re/public/overlays/sidecar/sidecar_service.mock.ts](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/5920?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project#diff-c3JjL2NvcmUvcHVibGljL292ZXJsYXlzL3NpZGVjYXIvc2lkZWNhcl9zZXJ2aWNlLm1vY2sudHM=) 62.50% [3 Missing ⚠️ ](https://app.codecov.io/gh/opensearch-project/OpenSearch-Dashboards/pull/5920?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=opensearch-project) These two are originally missing and file to create mock for test.
Hi @ashwin-pc @kavilla, most tests for this PR have been updated, please feel free to review. I will also try to add some cypress tests in functional test repo to...
Hi Kevin @kgcreative , as I discussed with Ashwin above, there may exist some components in this PR that we can potentially support in OUI for code reuse in future,...
@ruanyl I have created an issue in OUI to track this https://github.com/opensearch-project/oui/issues/1257. We could do component reuse. I can't be sure now that we can add a `rezableButton` component, at...
> Yeah I'm okay with a follow-up task for OUI. Can you create the issue and link it here. Can you do a few things for this PR: > >...