collector supervisord is not aware of go-ping

[Dieterbe]

trafficstars

supervisorctl restart all results in

collector: stopped
collector: started
[2015-06-25 22:52:11.651] [ERROR] PID:221 - listen tcp 127.0.0.1:8080: bind: address already in use

[2015-06-25 22:52:11.652] [ERROR] PID:221 - Ping server terminated.
[2015-06-25 22:52:11.775] [INFO] PID:230 - connected to socket.io server
[2015-06-25 22:52:11.776] [INFO] PID:229 - connected to socket.io server
[2015-06-25 22:52:12.653] [INFO] PID:221 - starting up go-ping server
[2015-06-25 22:52:12.659] [INFO] PID:221 - Go-Ping server starting up.

[2015-06-25 22:52:12.659] [ERROR] PID:221 - listen tcp 127.0.0.1:8080: bind: address already in use

because go-ping keeps running and collector tries to start it again. i would kill go-ping myself so supervisord can bring up collector and collector can bring up go-ping but it always gets restarted automatically

[Dieterbe]

actually pkill -f go-ping; supervisorctl restart all seems to work most of the time, as a workaround

[Dieterbe]

am I the only one hitting this problem? @ctdk @woodsaj am I missing something?

[woodsaj]

We will be rewriting the collector completely in go in the coming weeks. so i dont think there is a pressing need to fix this version.

If anything this should be fixed in raintank/raintank-collector not in the supervisord config. go-ping is launched by app.js, so app.js should be responsible for the start/stop and cleanup of this process.

[ctdk]

What Mr. Woods said. (Damn you "Unanswered By Me"!)