Rainer Sigwald

Results 248 comments of Rainer Sigwald

> we do not have ASTs of conditions We do actually! It's like the only grown-up PL part of MSBuild. Check out `src\Build\Evaluation\Conditionals\EqualExpressionNode.cs` and that folder. But that doesn't change...

From cmd, I find myself doing * `dir /s /b` * `rd /s /q`

This is a mitigation for #2835. > this functionality is not supported inside targets and the engine silently does nothing Nit: the problem isn't that the engine does nothing, it's...

This is not related to #3538--that's about the update mechanism that has existed ~forever, rather than the Update attribute. Indeed, honoring the attribute would be a breaking change 😢

> I believe we should test the case of explicit entry target (or implicit default target) and identical initial target - as then the same target should be executed twice...

> In general - target can execute multiple times if not properly input/output attributed, right? Within a single project instance in a single build, the engine should never run the...

I don't have a strong objection to this, other than the conflict-with-task one. But it's not very high on my priority list, personally. Anybody else feel more strongly about it?

Team triage: #3851 is a solid-looking implementation of this, but we currently think we should wait for a major release to add this type of language feature. If we want...

> * Add ability to add pre- and post- build targets on solution metaproj (though - this might not work in VS, this would not work for builds initiated not...

See for example the solution-level NuGet restore stuff: 1. Gets imported to solution metaprojects through https://github.com/dotnet/NuGet.BuildTasks/blob/4caf040c5a74b633c2260d7a8744737a93942a84/src/Microsoft.NuGet.Build.Tasks/ImportBeforeAfter/Microsoft.NuGet.Solution.ImportAfter.targets 2. Does special solution-y things via checks on this condition https://github.com/NuGet/NuGet.Client/blob/4020570fd78096035b551a5ac0869ca995f4dbed/src/NuGet.Core/NuGet.Build.Tasks/NuGet.targets#L55