react-redux-socketio-chat icon indicating copy to clipboard operation
react-redux-socketio-chat copied to clipboard

Published 20 hours ago • verified publisher icon raineroviir

Add the README file by translating it into Korean.

Open beom-i opened this issue 5 years ago • 2 comments

And I have a question about your README file. Is mdal correct in line 56 of README? not model?

And plz take my pull request if you need it. Thanks...!

beom-i avatar Dec 16 '19 10:12 beom-i

Is mdal correct in line 56 of README? not model?

I'm using modal to refer to modal window https://en.wikipedia.org/wiki/Modal_window.

As far as your pull request, I think it's really cool ! :) But it does not make sense to append the korean translation to the bottom of the english readme. If you moved the translation to a Readme_kr.md file and then linked to that file from the english readme that would be something I'd pull in.

raineroviir avatar Dec 19 '19 21:12 raineroviir

First of all, thank you very much. It's not enough, but I'd appreciate it if you could check it one more time!!!!!! ​ -----Original Message----- From: "Rainer Oviir"[email protected] To: "raineroviir/react-redux-socketio-chat"[email protected]; Cc: "beom-i"[email protected]; "Author"[email protected]; Sent: 2019-12-20 (금) 06:59:48 (GMT+09:00) Subject: Re: [raineroviir/react-redux-socketio-chat] Add the README file by translating it into Korean. (#66)

Is mdal correct in line 56 of README? not model?

I'm using modal to refer to modal window https://en.wikipedia.org/wiki/Modal_window. As far as your pull request, I think it's really cool ! :) But it does not make sense to append the korean translation to the bottom of the english readme. If you moved the translation to a Readme_kr.md file and then linked to that file from the english readme that would be something I'd pull in. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

beom-i avatar Dec 20 '19 03:12 beom-i