rainbowkit icon indicating copy to clipboard operation
rainbowkit copied to clipboard

[bug] connect modal not showing custom wallet button

Open technophile-04 opened this issue 11 months ago • 3 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

RainbowKit Version

^2.0.4

wagmi Version

^2.5.11

Current Behavior

The custom wallet button is not rendered inside connect modal when having custom connector + custom wallet.

Expected Behavior

Similar to rainbowkit v1 it should render custom wallet button in connect modal.

Steps To Reproduce

For easy debuggin and MRR, I have just forked this rainbowkit repo and added our custom connector to packages/examples dir. It has very minimal changes, checkout the file changes here => https://github.com/technophile-04/rainbowkit/pull/1/files

Steps to setup :

  1. Clone the repo + switch to branch :
git clone -b burner-mrr https://github.com/technophile-04/rainbowkit.git
  1. Cd in dir and pnpm install :
cd rainbowkit && pnpm install
  1. Run the dev server :
pnpm run dev
  1. Visit https://lochost:3000

Steps to reproduce :

  1. Make sure you disconnect from metamask / any other wallet
  2. Refresh the page and should be automatically connected to randomly generate account (burner account)
  3. Disconnect and notice that burner wallet button is not rendered in connect modal
Example Video :

https://github.com/rainbow-me/rainbowkit/assets/80153681/51578685-7994-47cf-9aca-ad20c8dd32a5

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

https://github.com/technophile-04/rainbowkit/pull/1/files

Anything else?

Context :

We have been trying to migrate from wagmi v1 => v2 in https://github.com/scaffold-eth/scaffold-eth-2/pull/700, everything works fine with burner wallet being connected and making transactions also no TS errors.

But when you disconnect and try to connect, the burner wallet button does not show up in connect modal

Wagmi, Rainbow V1 Wagmi, Rainbow V2
Screenshot 2024-04-01 at 2 57 55 PM Screenshot 2024-04-01 at 3 14 08 PM

technophile-04 avatar Apr 01 '24 09:04 technophile-04