rainbow icon indicating copy to clipboard operation
rainbow copied to clipboard

fix wallets loading on switch

Open natew opened this issue 8 months ago • 3 comments

Quick fix that avoids the wallet balance going into a loading state after every switch wallet.

natew avatar Jun 16 '25 17:06 natew

Launch in simulator or device for 7e7f8393cb34375ad7f2f0e5e74a25fa1b673296

jinchung avatar Jun 16 '25 18:06 jinchung

Taking a deeper look, I actually think we need some sort of variation of this function there. I'd reevaluate the need to refresh the wallet data though which is called internally of that loadWallets function.

walmat avatar Jun 17 '25 14:06 walmat

@walmat Did you find a case where it breaks? I tested a few different paths and they all seemed fine, so jw what case breaks?

The other wallet cleanup PR fixes this in a better way, but I thought this one is fine if that one takes longer than this release cycle to approve.

natew avatar Jun 17 '25 16:06 natew

Going to just close this in favor of https://github.com/rainbow-me/rainbow/pull/6642

natew avatar Jun 20 '25 16:06 natew