rainbow icon indicating copy to clipboard operation
rainbow copied to clipboard
verified publisher icon rainbow-me

Remove direct usage of web3Provider

Open jinchung opened this issue 1 year ago • 3 comments

Fixes APP-1925

What changed (plus any additional context for devs)

  • As part of removing the direct import and usage of web3Provider, I made some functions require a mandatory provider param
  • Moved over to using the getProvider function

Screen recordings / screenshots

Sending: https://github.com/user-attachments/assets/9448ddff-7413-43c2-847b-3075125599e7

Offline toast: https://github.com/user-attachments/assets/b361229c-65f8-434f-b96e-c795cf3cab76

What to test

  • sending on various networks
  • executing swap transactions on various networks
  • WalletConnect transactions and message signing
  • speed up and cancel txns across various networks
  • check OfflineToast behaves as expected
  • updating Showcase behaves as expected

jinchung avatar Oct 13 '24 20:10 jinchung

APP-1925 Remove all direct imports and usage of web3Provider

linear[bot] avatar Oct 13 '24 20:10 linear[bot]

Launch in simulator or device for f3334eb36b7b68301037a76de62fdfe4c52d1f6d

brunobar79 avatar Oct 16 '24 19:10 brunobar79

Launch in simulator or device for afec91fdbe750685be4aff0148581df065cc19ff

brunobar79 avatar Oct 17 '24 17:10 brunobar79