rainbow icon indicating copy to clipboard operation
rainbow copied to clipboard

fix position total value display

Open greg-schrammel opened this issue 1 year ago • 4 comments

Fixes APP-####

What changed (plus any additional context for devs)

some positions are omitted from the total wallet balance, but should still display the position value in the position card

Screen recordings / screenshots

before/after

Screenshot 2024-10-09 at 20 14 44 Screenshot 2024-10-09 at 20 14 48

What to test

greg-schrammel avatar Oct 09 '24 23:10 greg-schrammel

Launch in simulator or device for 1b40042fcc6990b474d0489583c1a72d43e873a4

brunobar79 avatar Oct 10 '24 00:10 brunobar79

@greg-schrammel, code looks good but I'm unsure what to test. Is the moxie case the only thing I should test or are there other considerations?

derHowie avatar Oct 10 '24 15:10 derHowie

@greg-schrammel, code looks good but I'm unsure what to test. Is the moxie case the only thing I should test or are there other considerations?

yeah the only positions I know that can have the omit_from_total flag rn are moxie

greg-schrammel avatar Oct 10 '24 16:10 greg-schrammel