rainbow icon indicating copy to clipboard operation
rainbow copied to clipboard

User assets migration

Open benisgold opened this issue 1 year ago • 11 comments

Fixes APP-1644, APP-1822

What changed (plus any additional context for devs)

Currently there is a mismatch between user assets within swaps and user assets elsewhere in the app because we have two different user assets queries. This PR migrates all usage of user assets over to the newer query located at src/__swaps__/screens/Swap/resources/assets/userAssets.ts and removes usage of the old query (and related code) located at src/resources/assets/UserAssetsQuery.ts. The new user assets data is primarily accessed through the userAssetsStore.

Screen recordings / screenshots

What to test

will build a TF but having build issues rn

i encourage thorough testing of all features involving using assets including sends, swaps, wallet screen, change wallet sheet, wallet switching, persistence

benisgold avatar Aug 23 '24 15:08 benisgold

Launch in simulator or device for 8f2df41a243e6d65b3f5e10bb6ef5723f04d2338

brunobar79 avatar Sep 10 '24 19:09 brunobar79

Launch in simulator or device for ecd10b61c02990646f30ff4d58d12594bfb4c015

brunobar79 avatar Sep 16 '24 17:09 brunobar79

Launch in simulator or device for 47f83177323224cd2e685f4bf31f7e700614e1f4

brunobar79 avatar Sep 16 '24 22:09 brunobar79

Launch in simulator or device for d94abd6afd90c4d1da09f60e21bb45a17b8ef560

brunobar79 avatar Sep 17 '24 14:09 brunobar79

Launch in simulator or device for afd961799b185648a96cfae298655e982e9b95da

brunobar79 avatar Sep 17 '24 15:09 brunobar79

Launch in simulator or device for 4705df3b5ef372de4f5c6fbd5f840081f21f3f25

brunobar79 avatar Sep 17 '24 17:09 brunobar79

Launch in simulator or device for 14548c1feef17cbceca73219d45c856e3c2a3e07

brunobar79 avatar Sep 17 '24 19:09 brunobar79

Launch in simulator or device for 653a480d560f838c5d495a058ebf343cf22227f3

brunobar79 avatar Sep 19 '24 01:09 brunobar79

Launch in simulator or device for 612b42412e1b63ad82b612f9edfce18fe03fd75d

brunobar79 avatar Sep 25 '24 15:09 brunobar79

@benisgold can you take a look at these conflicts?

derHowie avatar Dec 11 '24 14:12 derHowie

Launch in simulator or device for 93642909166eafd73fd96792fe9be22781519d66

brunobar79 avatar Dec 11 '24 17:12 brunobar79

Launch in simulator or device for 67753911e25171d4d86fa094130313bacfee44ad

brunobar79 avatar Dec 11 '24 21:12 brunobar79

Launch in simulator or device for a226781011ee592cea04392499cf4f9dc022b444

brunobar79 avatar Dec 12 '24 00:12 brunobar79

Launch in simulator or device for 925ee0e6071688ec61e665abe8f961f8a81a2de5

brunobar79 avatar Dec 12 '24 15:12 brunobar79

Launch in simulator or device for c69381695ce9139df8c2eeb0bd2193ed8f0e733a

brunobar79 avatar Dec 18 '24 23:12 brunobar79