rainbow-me
ledger clear signing upgrades
Fixes APP-####
What changed (plus any additional context for devs)
- Upgraded
@ledgerhq/hw-app-ethand@ledgerhq/react-native-hw-transport-ble - The upstream issue that required the patch was corrected.
- These upgrades will allow for Clear Signing with newer Ledger firmware versions
Screen recordings / screenshots
What to test
- Pairing and Signing with Ledger devices. Should try on a Ledger with an older firmware version and a recent firmware version (this month)
- Signing for popular dApps like Lido or Uniswap should not display a Blind Signing warning (new aggressive warning)
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/[email protected], npm/[email protected]
![socket-security[bot] avatar](https://avatars.githubusercontent.com/in/156372?v=4 "Published by a pub.dev verified publisher"){kind=small}
@BrodyHughes Have two of these PRs for App and BX related to a Ledger change to Blind Signing warnings. Just need to test that Ledger functionality is still working as expected. We are in the process of submitting metadata for our contracts to remove warnings which might be a follow-up. More details here: https://linear.app/rainbow/issue/APP-1731/ledger-removal-of-blind-signing
I don't have a ledger so can't really review this PR. Going to remove my request for review.
Adding my slack comment here so we don't lose it:
Ledger testing:
- TF 1.9.41 (6)
- Ledger Nano X
- Hardware: Ledger NanoX V2.0
- Firmware: Secure Element v2.2.3 // Microcontroller 2.30 // Bootloader 1.16
okay i’m not sure if the app is even asking for bluetooth permissions correctly? i am also stuck on the import flow trying to connect to ledger.
can confirm:
- connects to phone bluetooth
- connects to ledger live app
- ledger live settings show bluetooth permissions allowed
- rainbow does NOT show bluetooth permissions allowed
- rainbow does NOT prompt me for bluetooth permissions
