rainbow icon indicating copy to clipboard operation
rainbow copied to clipboard

Fix spacing issues on transaction review sheet

Open tchayen opened this issue 2 years ago • 1 comments

Fixes RNBW-4254 Figma link (if any):

What changed (plus any additional context for devs)

I replaced text components with new design system. The "trade off" is that DS doesn't support 26px size which is used here (max is 23).

Screen recordings / screenshots

Screenshot_20220811-005652_Rainbow

What to test

Final checklist

  • [x] Assigned individual reviewers?
  • [x] Added labels? (team1/team2, critical path, release, dev QA)
  • [x] Did you test both iOS and Android?
  • [x] If your changes are visual, did you check both the light and dark themes?
  • [x] Added e2e tests? If not, please specify why
  • [x] If you added new critical path files, did you update the CODEOWNERS file?
  • [x] If no dev QA label, did you add the PR to the QA Queue?

tchayen avatar Aug 10 '22 22:08 tchayen

RNBW-4254 [Android] Need padding on txn review sheet

This is how it looks on a Pixel 2 real device

image.png

Samsung Galaxy Note 9 real device

image.png

Steps to reproduce:

  • paste a long ENS into the address bar when sending ETH/ERC20/L2 txn for example brunobar79.argent.xyz (make sure it's the first time you're sending to that ENS)
  • Make sure you use a long name as well, sometimes it doesnt happen with shorter names. brunobar79.argent.xyz works fine.
  • on Review Sheet ensure the spacing between the name and "First time send" is correct

Devices reproduced on:

  • Pixel 6, Android 12 (Brody)
  • Pixel 2 (Ibrahim )
  • Galaxy 9 (Ibrahim)

linear[bot] avatar Aug 10 '22 22:08 linear[bot]

Screenshot 2022-08-18 at 10 52 42

Christian reminded me that there is the heading component, which solves the problem with size. Now there's full compatibility with design and android is not broken anymore.

tchayen avatar Aug 18 '22 08:08 tchayen