rainbow icon indicating copy to clipboard operation
rainbow copied to clipboard

Fix long press on address in switching wallets

Open tchayen opened this issue 2 years ago • 2 comments

Fixes RNBW-4243 Figma link (if any):

What changed (plus any additional context for devs)

Wallet switching supports long press NOT in the edit mode on Android again.

NOTE: there is also one change on Android in comparison to prod: due to how anchoring of the context menu works, the context menu in edit mode appears only when pressing the edit button, not the whole row.

Screen recordings / screenshots

Fix:

https://user-images.githubusercontent.com/5769281/183931860-255d3b92-b165-4590-969e-25235d6b4e9f.mp4

What to test

See the attached video. Check wallet switching sheet. Try pressing, long pressing etc.

Final checklist

  • [x] Assigned individual reviewers?
  • [x] Added labels? (team1/team2, critical path, release, dev QA)
  • [x] Did you test both iOS and Android?
  • [x] If your changes are visual, did you check both the light and dark themes?
  • [x] Added e2e tests? If not, please specify why
  • [x] If you added new critical path files, did you update the CODEOWNERS file?
  • [x] If no dev QA label, did you add the PR to the QA Queue?

tchayen avatar Aug 10 '22 14:08 tchayen

RNBW-4243 [Android] No longer able to delete address with long press

Only effects Android devices

Build/Branch = rc-v1.7.0 as of commit d9dbad2a7389a4b65bc492b2036c615efbb1b7df

Current Prod/Playstore Behavior:

9c531801-084f-4ecc-a32e-f8ae6926c5c6

Current behavior on rc-v1.7.0:

411d4785-593e-4705-a578-8992866a3f1d

Expected Behavior = should work how it does currently on Playstore, if you long press an address, menu should pop up with the option to delete

steps to reproduce:

  • On an android device ensure you have multiple wallets
  • Open the wallet switcher and long press any wallet to attempt to delete

linear[bot] avatar Aug 10 '22 14:08 linear[bot]

Blocked by design review. We are considering not enabling this again.

tchayen avatar Aug 10 '22 18:08 tchayen

Updated with changes from design review. Re-requested review from @perunt and @terrysahaidak. Added to QA queue again.

tchayen avatar Aug 24 '22 11:08 tchayen

Refer to this comment: Linear for current spec.

tchayen avatar Aug 24 '22 11:08 tchayen

@estebanmino oops, sorry. I fixed it now.

https://user-images.githubusercontent.com/5769281/186683736-2d3b1a68-7c58-4702-b2cf-6d435a317c6e.mov

(I pushed another commit which fixed spacing issue – now it's possible to tap anywhere to edit on Android, previously it was only name or edit button)

tchayen avatar Aug 25 '22 13:08 tchayen