rainbow icon indicating copy to clipboard operation
rainbow copied to clipboard

Add eslint rule for lodash

Open perunt opened this issue 2 years ago • 3 comments

Fixes RNBW-####

What changed (plus any additional context for devs)

Added eslint rules for preventing importing some lodash methods Also replaced startCase

PoW (screenshots / screen recordings)

Dev checklist for QA: what to test

Final checklist

  • [x] Assigned individual reviewers?
  • [x] Added labels?
  • [ ] Added e2e tests? if not please specify why
  • [ ] If you added new files, did you update the CODEOWNERS file?

perunt avatar Jun 27 '22 04:06 perunt

Since we use Hermes, it was decided to remove the lodash.debounce package and use it directly from lodash + write eslint rules to exclude importing other methods of lodash. We will add only the part of the code we use to the bundle, so it will not be expensive.

perunt avatar Jul 05 '22 11:07 perunt

Same with this one. Whenever u get to fix the conflicts LMK and I'll review right away

brunobar79 avatar Jul 14 '22 14:07 brunobar79

@perunt should we just re-implement this one with a fresh branch? I know this was a result of the prettier update, sorry about that.

estrattonbailey avatar Sep 21 '22 16:09 estrattonbailey

Please do not delete branch we will need this since we want to implement this anyway

jkadamczyk avatar Oct 10 '22 12:10 jkadamczyk