nixpacks icon indicating copy to clipboard operation
nixpacks copied to clipboard

Support reading files with non utf8 encoding

Open coffee-cup opened this issue 2 years ago • 1 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Describe the bug

If a file (such as requirements.txt) is not in a valid utf8 encoding, we should still support reading it

image

To reproduce

No response

Expected behavior

No response

Environment

Nixpacks v0.14.0

coffee-cup avatar Nov 22 '22 06:11 coffee-cup

For requirements.txt, we should be consistant with pip spec. https://pip.pypa.io/en/stable/reference/requirements-file-format/#encoding

Requirements files are utf-8 encoding by default and also support PEP 263 style comments to change the encoding (i.e. # -- coding: --).

Miloas avatar May 12 '23 17:05 Miloas