nixpacks icon indicating copy to clipboard operation
nixpacks copied to clipboard

Make staticfile provider better

Open Milo123459 opened this issue 1 year ago • 6 comments

The staticfile provider should be better in these ways:

  • If a build command can be found, run that build command and attempt to start with Staticfile provider if it matches the criteria
  • The Staticfile should allow for more configuration (TBD, but there is definitely more we can support)

Milo123459 avatar Sep 14 '22 20:09 Milo123459

What do you mean by "If a build command can be found".

If you mean run another providers setup/install/build commands, then that will be solved via the multiple providers implementation.

coffee-cup avatar Sep 14 '22 20:09 coffee-cup

Oh yeah, completely forgot about that.

Milo123459 avatar Sep 14 '22 20:09 Milo123459

Also, what are the additional configuration options? Ideally a GitHub issue is something that can be picked up and worked on by anyone, but "more configuration" without concrete details or examples is very open-ended and often leads to issues being open forever as there is no clear "this is complete" point.

coffee-cup avatar Sep 14 '22 20:09 coffee-cup

Nginx configuration mainly, as I have seen quite a few users request that.

Milo123459 avatar Sep 14 '22 20:09 Milo123459

possibly allow for servers other than nginx to be used? for example the npm serve package

nebulatgs avatar Sep 14 '22 21:09 nebulatgs

Now that multiple providers are supported, we should potentially look into this. Run the build command, then if no start command can be found but the staticfile provider is matched, use it.

Milo123459 avatar Dec 23 '22 02:12 Milo123459