nixpacks
nixpacks copied to clipboard
feat: suppport for NX monorepos
What does this PR address?
Out of the box support for NX mono repos. ( nexjs apps, express apps and apps that build to an index.js )
- [X] Make sure to follow GitHub's guide on creating PR.
- [x] Did you read through contribution guidelines?
- [x] Did your changes require updates to the documentation? Have you updated those accordingly? - New env var so yes?
- [x] Did you write tests to cover your changes? Did it pass locally when running
cargo test
? - [x] Have you run
cargo fmt
,cargo check
andcargo clippy
locally to ensure that CI passes?
Think this is ready for a review whenever someone is free 😊
As a result of this provider, can we revert #382?
The reason we added it was for the nwl stuff
Tbh I have never needed this env var on Railway. Having said that @ChristianIvicevic said not having it causes a sigTerm? I have noticed a sig term on vercel before when using nx but it's very flakey and may be caused by me not setting this env var.
CI=true
makes a lot of sense with Node projects such as disabling watch modes for tools (such as tests) or in the case of Nx disabling the background daemon that caused SIGTERMs.
As a result of this provider, can we revert #382?
The reason we added it was for the nwl stuff
This PR does not change the fact that CI=true
is needed. It just adds better first class support for NX apps.
Think all the ducks are in order now. This should be ready for a re-review whenever you are free next week or so 😀.
Done!
Odd, somehow I missed some. I'll get on that asap tomorrow.
I just went ahead and fixed the remaining lint errors (Literally just had to run cargo clippy --fix
) 😄