upterm
upterm copied to clipboard
railsware
Native window controls (close, minimize, maximize) not showing on macOS
Before I upgraded to the latest version the controls looked something like this, which is what I would expect:
After I upgraded they looked like this:
Is this a bug or is this intentional? I see some commits related to custom/title bar but I can’t find any commit messages explaining the changes so I don’t know if this was supposed to happen or not, and why?
@itssimon did you check master branch? This fix was not published with some version.
Yes, I tried on the master branch. The fullscreen mode works though. Let me know if I can help track it down.
I was expected, that this PR fix this problem https://github.com/railsware/upterm/pull/1306
I think we might be talking about different things? It seems like the commit you’re talking about changes the behavior of the controls, but what I’m talking about is how the controls look.
On macOS they should be red, yellow, and green dots. But on the latest version they’re shown as a white “X“, “-”, and “+”.
The problem is it breaks the conventions and patterns used in macOS applications. macOS applications all use the same native window controls, and in the case of non-native applications, like an Electron app, they replicate the native controls. They do this both because it’s aesthetically pleasing but also because users follow the conventions and patterns in order to understand how the application they’re using works.
Or to make the argument a different way, what’s the value of changing the controls to look different from every other macOS application?
Ok, now I understand a problem. Thanks. Will check, how will look native toolbar not only on Mac OS.
Reverted by https://github.com/railsware/upterm/commit/dbcb73cdfa014c84f3ad2718faed6bff423ab95e
