sprockets icon indicating copy to clipboard operation
sprockets copied to clipboard
verified publisher icon rails

Drop base64 gem from dependency

Open tricknotes opened this issue 1 year ago • 1 comments

This following warning is shown in test.

/Users/ryunosuke.sato/src/github.com/rails/sprockets/lib/sprockets/mime.rb:2: warning: base64 was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.
You can add base64 to your Gemfile or gemspec to silence this warning.

Instead of adding base64 to dependency, the usage of Base64#strict_encode64 and Base64#encode64 have replaced with Array#pack.

Also, this PR fixes CI for Ruby 3.4-dev.

Note: Similar PRs are here

  • https://github.com/httprb/http/pull/778
  • https://github.com/rubocop/rubocop/pull/12313
  • https://github.com/rack/rack/pull/2110
  • https://github.com/elastic/elasticsearch-ruby/pull/2295
  • https://github.com/socketry/protocol-http/pull/51
  • https://github.com/lautis/uglifier/pull/195

tricknotes avatar Sep 21 '24 12:09 tricknotes

This PR and https://github.com/lautis/uglifier/pull/195 will fix CI against ruby 3.4.0-dev.

tricknotes avatar Sep 21 '24 12:09 tricknotes

@byroot Could you review this PR?

tricknotes avatar Oct 01 '24 14:10 tricknotes

👋🏻 Hey, y'all, thanks for getting this update in. Would it be possible to cut a new point release to RubyGems with this fix?

jgarber623 avatar Apr 17 '25 02:04 jgarber623

I just released 4.2.2

byroot avatar Apr 19 '25 03:04 byroot