rails-observers icon indicating copy to clipboard operation
rails-observers copied to clipboard

Add support for after_create_commit, after_update_commit and after_destroy_commit

Open cfis opened this issue 7 years ago • 9 comments

This is a follow up to #50. These three callbacks were added in Rails 5 as aliases for using after_commit callback only on create, update or delete. Thus they are not actually part of ActiveRecord::Callbacks::CALLBACKS but instead are defined active_record/transactions.rb

cfis avatar Oct 09 '17 04:10 cfis

Any progress on merging this?

bhalash avatar Oct 21 '17 13:10 bhalash

Can we have tests to cover this?

rafaelfranca avatar Oct 25 '17 16:10 rafaelfranca

I'll take care of this.

bhalash avatar Oct 26 '17 08:10 bhalash

@bhalash any progress on this? Thanks

GContaldi avatar Nov 21 '17 11:11 GContaldi

@GContaldi Sorry, it turns out that I've been rather busy lately. I hope to have time to tackle it before the end of this week.

bhalash avatar Nov 21 '17 11:11 bhalash

@bhalash thanks a lot for the prompt response :)

GContaldi avatar Nov 21 '17 11:11 GContaldi

@GContaldi Update: I'm resource constrained in my job (sole developer), but we've slated time for next week to get this done. Busy busy. -_-

bhalash avatar Nov 28 '17 11:11 bhalash

Any progress on this? From reading the comments it seems it has been over a year. I am currently in need of these callbacks supported for observers after upgrading to Rails 5. Thanks.

nrvakil avatar Nov 15 '18 07:11 nrvakil

@nrvakil I haven't worked with Rails since May. The developers (pinging @GContaldi and @rafaelfranca ) have not responded to this pull request for whatever reason. ¯\_(ツ)_/¯

You are free to pull it and update the PR yourself, sorry man!

bhalash avatar Nov 15 '18 12:11 bhalash