rails-observers icon indicating copy to clipboard operation
rails-observers copied to clipboard

Published 20 hours ago • verified publisher icon rails

Mention the "after_commit" callback in the README

Open donv opened this issue 8 years ago • 3 comments

So that new developers can know that it exists, and know when it is called.

donv avatar Mar 07 '16 12:03 donv

Feel free to submit a pull request.

rafaelfranca avatar Mar 07 '16 20:03 rafaelfranca

Hi @rafaelfranca !

Thanks for the quick response. I'll submit a PR, but I have one question first: Should "after_commit" be called for an update that is stopped by the "dirty" module since there were no changes? I would expect not, but I think I see this in at least one of our apps.

Just to clarify for the README change.

donv avatar Mar 07 '16 20:03 donv

If no commits are made to the database it should not run. If it is happen seems like a bug.

rafaelfranca avatar Mar 07 '16 20:03 rafaelfranca