prototype-ujs icon indicating copy to clipboard operation
prototype-ujs copied to clipboard

:confirm option on buttons (button_to, button_tag) not working for me

Open jotto opened this issue 13 years ago • 2 comments

the :confirm option on buttons isn't working for me, but works for link_to. i can find no evidence of this breaking for others via google so i suspect i might having something else wrong.

<%= button_to "text", "/", :confirm => "are you sure?" %>

yields

<input data-confirm="are you sure?" name="commit" type="submit" />

but line 159 of rails.js

   document.on('click', 'a[data-confirm], a[data-remote], a[data-method]', function(event, link) {

isn't observing any input buttons. adding input[data-confirm] works for me, but is this suppose to be working without that addition?

jotto avatar May 10 '11 03:05 jotto

It appears the *[data-confirm] selector was removed in this commit to fix reliability issues in IE.

I've added input[data-confirm], button[data-confirm] like you said, and it appears to work in IE6/7/8.

domchristie avatar Oct 03 '11 16:10 domchristie

Update: this is fixed on my fork: (see #11). Looking at jquery_ujs, it appeared that the form button click handler was missing a call to allowAction().

domchristie avatar Oct 06 '11 22:10 domchristie