prototype-rails fix assert_select wanting something to call .css on

@pschambacher

Mar 15 '16 05:03 grosser

otherwise

assert_select_rjs do
        assert_select "#1"
end

fails with nasty undefined method css for Array :(

Mar 15 '16 05:03 grosser

Yes please

Mar 15 '16 10:03 pschambacher

@rafaelfranca this is some old 💩 but we still need that :D

Jun 15 '17 19:06 grosser

yeah I guess you are right ... this is too dirty ... I'll just leave this here as docs and try again to kill prototype instead :/

Jun 15 '17 21:06 grosser

What I did in Shopify was to keep the prototype JavaScript code and just remove all ruby methods calls that we had.

Jun 15 '17 21:06 rafaelfranca

I think we are ready to remove prototype ... lots of old routes gone now ... so maybe worth a new try :)

On Thu, Jun 15, 2017 at 2:52 PM, Rafael França [email protected] wrote:

What I did in Shopify was to keep the prototype JavaScript code and just remove all ruby methods calls that we had.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rails/prototype-rails/pull/39#issuecomment-308876113, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAsZ5lCjHaPYZQn5_FIER9dyLO7eSkVks5sEaewgaJpZM4HwuGW .

Jun 15 '17 21:06 grosser