jquery-ujs icon indicating copy to clipboard operation
jquery-ujs copied to clipboard

$.rails undefined with jquery 3.4.0

Open phoet opened this issue 5 years ago • 10 comments

our automated @depfu yarn updates had some errors in our system-tests.

with jquery 3.4.0 there are some problems with jquery-ujs and other libraries such as bootstrap-datepicker.

i'm not completely sure what is happening there. just leaving this here in case anyone else finds related issues.

phoet avatar Apr 23 '19 11:04 phoet

it looks like this is because of https://github.com/yarnpkg/yarn/issues/4125

it looks like it got fixed here, but i assume no new version has been released to NPM?

Screen Shot 2019-04-23 at 16 01 35

phoet avatar Apr 23 '19 14:04 phoet

@theflow 👀 i guess that there will be many issues that like that with your js builds

phoet avatar Apr 24 '19 08:04 phoet

@rafaelfranca could you take a look and verify that this will need a new npm release? thx!

phoet avatar Apr 24 '19 08:04 phoet

@lucasmazza do you know who can be asked about releasing a new npm version of this?

phoet avatar May 06 '19 10:05 phoet

😿

phoet avatar May 15 '19 17:05 phoet

☝️ ping @rafaelfranca

lucasmazza avatar May 15 '19 18:05 lucasmazza

@phoet hitting the same issue, have you found any workarounds?

klaustopher avatar Jul 25 '19 14:07 klaustopher

@klaustopher editing the yarn.lock by hand...

phoet avatar Jul 25 '19 15:07 phoet

Hmm, ok .. I'd like to run the jquery update but if this is not possible, then we might need to always stay on 3.3.x ☹️

klaustopher avatar Jul 25 '19 15:07 klaustopher

It is possible, just yarn thinks it should use different versions for your dependencies. If you update and them merge both dependencies in your yarn.lock everything works fine.

phoet avatar Jul 25 '19 16:07 phoet