jquery-ujs
jquery-ujs copied to clipboard
Add handling on select[required] elements
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
Huh. Weird that we didn't have this. Here is the relevant HTML spec which states that select
inputs may have the required
attribute and be enforced.
I haven't run the tests yet, but the code looks good to me on first pass.