execjs icon indicating copy to clipboard operation
execjs copied to clipboard

Support complex context in Duktape by using eval

Open maisumakun opened this issue 8 years ago • 4 comments

Just like ExecJS::ExternalRuntime::Context#call, not using Duktape's #call_prop but simple eval will solve #45 .

I don't know if there might be any side effects for this change, but it seems working.

maisumakun avatar Jul 07 '16 02:07 maisumakun

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rails-bot avatar Jul 07 '16 02:07 rails-bot

@rafaelfranca Any progress on this?

judofyr avatar May 29 '18 07:05 judofyr

It is missing tests, so it is hard to assert it is actually doing what it should

rafaelfranca avatar May 30 '18 03:05 rafaelfranca

I opened #76 to start a proper discussion around how to handle this issue

judofyr avatar May 30 '18 08:05 judofyr