execjs icon indicating copy to clipboard operation
execjs copied to clipboard

Whitespace in Windows Path results in binaries not being located

Open tristanchanson opened this issue 9 years ago • 1 comments

I found that when configuring to use NodeJS on windows binaries were not being located due to path containing spaces. Please accept this pull request which strips the whitespace from the paths found in windows.

Thanks,

tristanchanson avatar Oct 02 '15 15:10 tristanchanson

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rails-bot avatar Oct 02 '15 15:10 rails-bot