dartsass-rails icon indicating copy to clipboard operation
dartsass-rails copied to clipboard

README: Fix typo (missing space) on Rails.application.config.dartsass.build_options

Open navidemad opened this issue 1 year ago • 1 comments

In the README.md: Rails.application.config.dartsass.build_options << "--no-charset" << "--quiet-deps"

Produces with a fresh app:

02:56:29 css.1  | Could not find an option named "no-source-map--no-charset--quiet-deps".
02:56:29 css.1  |
02:56:29 css.1  | Usage: sass <input.scss> [output.css]
02:56:29 css.1  |        sass <input.scss>:<output.css> <input/>:<output/> <dir/>

By default Rails.application.config.dartsass.build_options is: --style=compressed --no-source-map

We have to add space before the first of each dashes. Rails.application.config.dartsass.build_options << " --no-charset" << " --quiet-deps"

navidemad avatar Jan 20 '24 02:01 navidemad

This README change was due to a yet to be release change on main branch which changed the default from a string "--style=compressed --no-source-map" to an array ["--style=compressed", "--no-source-map"], with the new array form you don't need that extra whitespace.

ntkme avatar Jan 25 '24 01:01 ntkme