activerecord-session_store icon indicating copy to clipboard operation
activerecord-session_store copied to clipboard

Retrieve session without any implicit ordering

Open denisj opened this issue 8 years ago • 6 comments

denisj avatar Feb 20 '17 13:02 denisj

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rails-bot avatar Feb 20 '17 13:02 rails-bot

@denisj please click rebuild in travis. In this there was temporary error in travis

dapi avatar Apr 24 '17 19:04 dapi

@dapi the errors still occur

denisj avatar Apr 25 '17 07:04 denisj

Could you explain why the change?

rafaelfranca avatar May 11 '17 21:05 rafaelfranca

@rafaelfranca I made that change to avoid implicit ordering on the primary key.

denisj avatar May 12 '17 07:05 denisj

Oh, interesting.

Sorry for just noticing this patch now. Would you mind rebasing against master so you'll pickup the new Travis build matrix and hopefully the CI will pass?

sikachu avatar Mar 01 '19 14:03 sikachu